Merge 2.0-bridge into master #2508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidiaz
force-pushed
the
bridge/2.0-integration
branch
from
8895514
to
07b37e6
Compare
guidiaz
force-pushed
the
bridge/2.0-integration
branch
2 times, most recently
from
e225245
to
1263d45
Compare
guidiaz
changed the title
guidiaz
force-pushed
the
bridge/2.0-integration
branch
3 times, most recently
from
e6c814d
to
2e670fe
Compare
aesedepece
force-pushed
the
master
branch
2 times, most recently
from
0f778f0
to
c37598b
Compare
guidiaz
force-pushed
the
bridge/2.0-integration
branch
from
aba8a0f
to
7105858
Compare
… connection status
guidiaz
force-pushed
the
bridge/2.0-integration
branch
from
7105858
to
767a00e
Compare
aesedepece
requested changes
Nov 13, 2024
| -A clippy::uninlined-format-args | ||
| -A renamed_and_removed_lints | ||
| ' | ||
| export CLIPPY_LINTS := '-D warnings -D clippy::cast-lossless -D clippy::cast-possible-truncation -D clippy::cast-possible-wrap -D clippy::cast-precision-loss -D clippy::cast-sign-loss -D clippy::checked-conversions -A clippy::upper-case-acronyms -A clippy::uninlined-format-args -A renamed_and_removed_lints' |
| 0, 0, 248, 117, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 16, 232, 36, 130, 44, 106, 92, | ||
| 40, 222, 53, 104, 223, 153, 96, 77, 104, 233, 253, 156, 140, | ||
| ]), | ||
| data: web3::types::Bytes(hex::decode("0000000000000000000000000000000000000000000000000000000000001b58000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000146e6f7420696e20506f7374656420737461747573000000000000000000000000").unwrap()), |
There was a problem hiding this comment.
Well done. I hate how much we rely on byte arrays all across the code base and in our APIs. Hex is the way to go.
|
Merged as of 67db70c ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.